Project ARES: Announcement Signatures #6030
Conversation
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Added the bits for security log, had to update some var names on other UIs to do so mind. |
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
In ARES_interface_apollo.dm there is still:
log_ares_security("Nerve Gas Release", "[last_login] released Nerve Gas from Vent '[sec_vent.vent_tag]'.")
In ARES_interface_admin.dm there is still:
log_ares_security("Nerve Gas Release", "[MAIN_AI_SYSTEM] released Nerve Gas from Vent '[sec_vent.vent_tag]'.")
In apollo_pda.dm there is still:
log_ares_security("Nerve Gas Release", "[last_login] released Nerve Gas from Vent '[sec_vent.vent_tag]'.")
In biohazard_lockdown.dm there is still:
var/ares_log = "[user.name] triggered Medical Research Biohazard Containment Lockdown."
log = "[key_name(user)] triggered research bio lockdown! (Using a custom announcement)."
ares_log = "[MAIN_AI_SYSTEM] triggered Medical Research Biohazard Containment Lockdown."
log = "[key_name(user)] lifted research bio lockdown!"
ares_log = "[user.name] lifted Medical Research Biohazard Containment Lockdown."
ares_log = "[MAIN_AI_SYSTEM] lifted Medical Research Biohazard Containment Lockdown."
log_ares_security("Containment Lockdown", ares_log)
About the pull request
ARES now logs who sent an announcement and not just the contents of it.
Explain why it's good for the game
Makes the available information a little more useful. It's all well and good recording what was said, but a little pointless if not including who said it.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
add: Added the name of an announcement sender, if one exists, to ARES logs.
/:cl: